Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Pre-Publish Steps): update service package version to 2.3 #1097

Merged
merged 4 commits into from
Mar 27, 2025

Conversation

Blahpapto1
Copy link
Contributor

@Blahpapto1 Blahpapto1 commented Mar 27, 2025

What does this Pull Request accomplish?

Pre-publish steps for releases/2.3.

Why should this Pull Request be merged?

Standard release procedure.

What testing has been done?

N/A - PR

@Blahpapto1 Blahpapto1 changed the title (Pre-Publish Steps): update ni-measurement-plugin-sdk-service to vers… (Pre-Publish Steps): update service package version to 2.3 Mar 27, 2025
@Blahpapto1 Blahpapto1 changed the base branch from main to releases/2.3 March 27, 2025 07:18
@Blahpapto1 Blahpapto1 marked this pull request as ready for review March 27, 2025 07:19
Copy link

github-actions bot commented Mar 27, 2025

Test Results

    52 files  ±0      52 suites  ±0   1h 17m 48s ⏱️ + 1m 27s
   709 tests ±0     709 ✅ ±0      0 💤 ±0  0 ❌ ±0 
21 420 runs  ±0  20 344 ✅ ±0  1 076 💤 ±0  0 ❌ ±0 

Results for commit a679d06. ± Comparison against base commit 948e927.

♻️ This comment has been updated with latest results.

@Blahpapto1
Copy link
Contributor Author

Blahpapto1 commented Mar 27, 2025

System Tests are failing because -

Because ni-measurement-plugin-sdk-generator depends on ni-measurement-plugin-sdk-service (^2.3.0) which doesn't match any versions, version solving failed.

For this, I can comment out the ni-measurement-plugin-sdk-service package to be used from ../... Will this be changed in the release branch once the packages are uploaded ? Post-publish steps ?

@bkeryan

Based on an earlier comment, it was not changed back after packages were published in releases/2.1 branch -

ni-measurement-plugin-sdk-service = {path = "../../packages/service", develop = true}

@bkeryan
Copy link
Collaborator

bkeryan commented Mar 27, 2025

System Tests are failing because -

Because ni-measurement-plugin-sdk-generator depends on ni-measurement-plugin-sdk-service (^2.3.0) which doesn't match any versions, version solving failed.

For this, I can comment out the ni-measurement-plugin-sdk-service package to be used from ../... Will this be changed in the release branch once the packages are uploaded ? Post-publish steps ?

@bkeryan

Based on an earlier comment, it was not changed back after packages were published in releases/2.1 branch -

ni-measurement-plugin-sdk-service = {path = "../../packages/service", develop = true}

I added a note to the wiki page clarifying this:

[!NOTE] The reason we comment out the file dependencies is so that the examples in the distribution .zip file work without the rest of the Git repo. Do not comment out the file dependencies for projects in packages/ because this reason does not apply to them and their build/test workflow requires file dependencies.

@bkeryan bkeryan merged commit 67199a6 into releases/2.3 Mar 27, 2025
16 of 17 checks passed
@bkeryan bkeryan deleted the users/avgoel/pre-publish-steps-2.3 branch March 27, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants