refactor(alarms): Remove Alarms Count query type and related code #533
+16
−528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ahalya-ni
changed the title
manisha-ni
approved these changes
Nov 19, 2025
1 task
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Ahalya-ni
force-pushed
the
users/ahalya/feat/remove-alarms-ref
branch
from
f6139b5 to
a8de716
Compare
Ahalya-ni
requested review from
hemkumarrao-ni,
kartheeswaran-ni and
ushakanagaraj-ni
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Task 3513145: PR2 | Remove Alarms Count reference
This PR removes all references to Alarms Count from the query type control, editors, query handlers, and related code.
Note: I've set the branch
users/ahalya/feat/output-type-uias the base for this branch to ensure this alarms count removal PR can only be merged after the output type is introduced. This provides a safe migration if any issues arise, we can refer the alarms count datasource as a backup.👩💻 Implementation
AlarmsCountEditorandAlarmsCountQueryHandler.🧪 Testing
✅ Checklist