Skip to content

Step8 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 11, 2025
Merged

Step8 #6

merged 3 commits into from
Mar 11, 2025

Conversation

ni4120
Copy link
Owner

@ni4120 ni4120 commented Mar 11, 2025

What

  • GitHub Actionsの有効化
  • .github/workflows/build.yml の修正
  • ローカルにPullして動作確認
docker pull ghcr.io/ni4120/mercari-build-training:step8
docker run -d -p 9000:9000 ghcr.io/ni4120/mercari-build-training:ni4120

CHECKS ⚠️

Please make sure you are aware of the following.

  • **The changes in this PR doesn't have private information

task4233
task4233 approved these changes Mar 11, 2025
View reviewed changes
Copy link

@task4233 task4233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

方針としては良さそうなので、 #5 をマージしてからこちらもマージしましょう！

@ni4120 ni4120 merged commit 2fa2259 into main Mar 11, 2025
1 check passed
@ni4120 ni4120 deleted the step8 branch March 11, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@task4233 task4233 task4233 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ni4120 @task4233