Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a boolean parameter to keep all dicom tags at loading #49

Open
ryder-cobean-nih opened this issue Aug 21, 2024 · 3 comments
Open

Add a boolean parameter to keep all dicom tags at loading #49

ryder-cobean-nih opened this issue Aug 21, 2024 · 3 comments

Comments

@ryder-cobean-nih
Copy link
Contributor

We use this library as part of a solution for auto-conversion to grayscale for batch data quality, and its failsafe means to open dicoms in edge case scenarios is very useful. For my purposes, I had to fork and hastily adjust the read_dcm module, to not remove metadata fields. might it be possible to add a boolean to that function, something like keep_tags, that rather than keeping only these :

_keyword_to_copy = [
    "StudyInstanceUID",
    "SeriesInstanceUID",
    "Modality",
    "PixelSpacing",
    "ImagerPixelSpacing",
    "DistanceSourceToDetector",
    "ViewPosition",
    "PatientSex",
]

it retains all dicom tags as seen at file open?

@blowekamp
Copy link
Collaborator

blowekamp commented Aug 21, 2024

Care to make a pull request with your proposed changes/feature?

@blowekamp
Copy link
Collaborator

@ryder-cobean-nih Can you share your proposed changes?

@ryder-cobean-nih
Copy link
Contributor Author

@blowekamp

Thanks and sorry for the delay!

Keep all tags by ryder-cobean-nih · Pull Request #50 · niaid/rap_sitkCore (github.com)

Take a look at those. Pretty minor change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants