Use passive: true in touchmove events#14
Conversation
Chrome Lighthouse is suggesting to pass passive: true to touchmove event listener.
|
There was a reason that I did not pass that option there but I can't remember. I'll have to dig in a little and get back to you on this one! |
|
If this gets merged we should also put it in https://github.com/nickschot/ember-gesture-modifiers |
|
I figured out the reason this was there was because we have the prevent scroll functionality which cannot be combined with a passive event listeren on touch move. However, I am unsure if this is actually needed. It will definitely be better to make the touchmove follow the same options as the other events. I'm gonna tinker a bit with what I want the setup to look like and get back to you. |
|
ember-gesture-modifiers was updated with a fix for this behaviour: https://github.com/nickschot/ember-gesture-modifiers/pull/11/files Passive will be true by default, false if the |
|
I'll migrate to |
Chrome Lighthouse is suggesting to pass passive: true to touchmove event listener.