-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for include and exclude patterns for project dependencies #113
base: master
Are you sure you want to change the base?
Conversation
Add support for include and exclude patterns for project dependencies nicoulaj#36 nicoulaj#36
Add support for include and exclude patterns for project dependencies nicoulaj#36 nicoulaj#36
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
============================================
+ Coverage 78.36% 78.62% +0.25%
Complexity 188 188
============================================
Files 27 27
Lines 661 669 +8
Branches 77 77
============================================
+ Hits 518 526 +8
Misses 112 112
Partials 31 31
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The naming of the new parameters is a bit inconsistent with the existing one: includeClassifiers
. Would you mind renaming to includeGroupIds
/ etc ?
Sure!
Viele Grüße
Thomas Büngener
…________________________________
From: nicoulaj ***@***.***>
Sent: Friday, May 14, 2021 8:28:25 PM
To: nicoulaj/checksum-maven-plugin ***@***.***>
Cc: Thomas Büngener ***@***.***>; Author ***@***.***>
Subject: Re: [nicoulaj/checksum-maven-plugin] Add support for include and exclude patterns for project dependencies (#113)
@nicoulaj requested changes on this pull request.
The naming of the new parameters is a bit inconsistent with the existing one: includeClassifiers. Would you mind renaming to includeGroupIds / etc ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#113 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAWHWSQE5OVKLEEXCIDY6T3TNVTUTANCNFSM44Y4QKJQ>.
|
Implemented the following feature request: #36