Skip to content

Fixes #72: Add django 3 support #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daniel-ruiz wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes #72: Add django 3 support #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40a5402
Add compatibility module
daniel-ruiz Dec 11, 2019
f6fd3b2
Drop usage of django.utils.six in favour of .compat module
daniel-ruiz Dec 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions easy_pdf/compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# coding=utf-8

import sys

__all__ = ['BytesIO']

PY2 = sys.version_info[0] == 2

if PY2:
import StringIO
BytesIO = StringIO.StringIO
else:
import io
BytesIO = io.BytesIO
2 changes: 1 addition & 1 deletion easy_pdf/rendering.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@
from django.template import loader
from django.http import HttpResponse
from django.utils.http import urlquote
from django.utils.six import BytesIO

import xhtml2pdf.default
from xhtml2pdf import pisa

from .compat import BytesIO
from .exceptions import UnsupportedMediaPathException, PDFRenderingError

logger = logging.getLogger("app.pdf")
Expand Down