Delete organisation #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prabhanshuguptagit
force-pushed
the
delete-organisation
branch
from
f9f7173 to
917f1d6
Compare
ssrihari
reviewed
Oct 1, 2019
| ([user-id org-id] | ||
| (get-permission (config/db-spec) user-id org-id)) | ||
| ([conn user-id org-id] | ||
| (-> (jdbc/query conn (-> (h/select :permission) |
ssrihari
reviewed
Oct 1, 2019
| (jdbc/with-db-transaction [trn (config/db-spec)] | ||
| (if (is-owner? trn id user-id) | ||
| (if-not (empty? (db/delete! trn id)) | ||
| {:success "Organisation deleted"}) |
There was a problem hiding this comment.
Since the else section is missing here, this returns nil. Is that okay?
ssrihari
reviewed
Oct 1, 2019
|
|
||
| (defn show-alert-bottom | ||
| [status message & [time]] | ||
| (let [time (if (number? time) (* time 1000) 4000)] |
There was a problem hiding this comment.
number? seems like the wrong check here. are you checking for presence?
There was a problem hiding this comment.
Checking if time is a number and is not nil.
Merged
prabhanshuguptagit
changed the base branch from
sidebar-navigate-orgs
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Raised against #12 for reviews only. Change base to master before merge.