Create categories ui #17
Conversation
prabhanshuguptagit
force-pushed
the
ui-create-category
branch
from
d1e8bb6 to
3af43a5
Compare
|
|
||
| (defn retrieve-by-org | ||
| [org-id] | ||
| (jdbc/find-by-keys (config/db-spec) :categories {:org_id org-id})) |
There was a problem hiding this comment.
[murtaza] Use an identifier and hyphenize the records you retrieve.
| (let [org-id (edn/read-string (get-in request [:params :org-id])) | ||
| user-id (get-in request [:identity :id])] | ||
| (if (s/valid? ::org-spec/id org-id) | ||
| (utils/model-to-http (models/retrieve-by-org org-id user-id) |
There was a problem hiding this comment.
Consider adding the message to the map you pass to utils/model-to-http with the response codes.
{:message (models/retrieve-by-org org-id user-id) :success ... :error ...}
|
|
||
| (defn create [category org-id handler error-handler] | ||
| (POST (create-category-api org-id) | ||
| {:body (.stringify js/JSON (clj->js category)) |
There was a problem hiding this comment.
Consider using cheshire
| [villagebookUI.fetchers :as fetchers] | ||
| [villagebookUI.store.categories :as category-store])) | ||
|
|
||
| (defn- category-active? |
There was a problem hiding this comment.
[murtaza] Rename this to category-selected??
| (on-mount-cb) | ||
| (fn [org categories] | ||
| [:div.content-box | ||
| [:div.category-tabs |
There was a problem hiding this comment.
[murtaza] Extract category-tabs out into a different function maybe?
| [villagebookUI.api.category :as api] | ||
| [villagebookUI.store.organisations :as org-store])) | ||
|
|
||
| (defn submit-create-category |
There was a problem hiding this comment.
[murtaza] This can be renamed to create-category.
| (api/create {:name name | ||
| :fields (map #(second %) fields)} | ||
| org-id | ||
| #(do | ||
| (fetchers/fetch-categories! org-id last) | ||
| (helpers/show-alert-bottom! :success (str "Category " name " created"))) | ||
| #(helpers/show-alert-bottom! :error (:response %))))) | ||
|
|
There was a problem hiding this comment.
[murtaza] Consider adding all of these parameters to a single map, and destructure it in the function.
(The category properties are added but not being displayed on the frontend atm.)
--
Raised against #12 for reviews only. Change base to master before merge.