Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable "dest register is set" for vm statements #24797

Merged
merged 2 commits into from
Mar 23, 2025
Merged

disable "dest register is set" for vm statements #24797

merged 2 commits into from
Mar 23, 2025
+11 −2

Conversation

metagn
Copy link
Collaborator

@metagn metagn commented Mar 22, 2025 •
edited
Loading

closes #24780

This proc genStmt is only called to run the VM in vm.evalStmt, otherwise it's not used in vmgen. Now it acts the same as proc gen(PCtx, PNode), used by discard statements, which just calls freeTemp on the dest if it was set rather than erroring.

@Araq Araq added the merge_when_passes_CI mergeable once green label Mar 22, 2025
@metagn metagn merged commit fcba147 into nim-lang:devel Mar 23, 2025
18 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from fcba147

Hint: mm: orc; opt: speed; options: -d:release
178834 lines; 8.843s; 651.379MiB peakmem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merge_when_passes_CI mergeable once green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nimscript: VM problem: dest register is set for top-level {.discardable.}s
2 participants
@metagn @Araq