Skip to content

Fix nimIoselector define in std/selectors #25104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

Fix nimIoselector define in std/selectors #25104

wants to merge 1 commit into from

Conversation

bptato
Copy link
Contributor

@bptato bptato commented Aug 16, 2025

Also added some documentation to the header.

See: https://forum.nim-lang.org/t/13311

I did try using the flag, but couldn't get it to work. If I do -d:nimIoSelector, the defined check passes, but the other code fails to compile because there is no const named nimIoSelector. It seemed like a bug to me, do you have a working number compiler invocation?

@bptato
Fix nimIoselector define in std/selectors
334eda1 
Also added some documentation to the header.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bptato