Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in Nim,
DIRis markedincompleteStruct.Since
DIRis forward declared, we can not access its size. We need to handle thesizeoffor it specificallyIn Nim, it causes problems for
genTypeInfo. And some (mis)usage still produce code gen errorsor use
DIRas fields of objects without reference, name usingDIRby valueIn Nimony, it seems that only
sizeofconcernsincompleteStructfor now, i.e.,sizeof(DIR). Since any type usingDIRbyvalue already produces code gen errors. This PR should make
sizeof(DIR)use the size of a pointer, whileincompleteStructmight be useful in the future