generic args unify - #2564
Merged
Merged
generic args unify#2564
Conversation
Type instantiation used semStaticInvokeArg, which semchecked static generic arguments as runtime values of the parameter's element type (e.g. openArray[int]). That rejected array literals that routine calls already accepted via staticValueToBind, so `Box[[1, 2, 3]]` failed while `countValues[[1, 2, 3]]()` worked. Route type instantiation through the same bind/validate pipeline as routine overload resolution: sem each explicit arg under AllowValues, then call matchGenericExplicitArgs and rewrite static args with buildCanonicalGenericArgs. Add genericParams to walk generic parameters of routines and types in one place; refactor matchTypevars to delegate. Remove the duplicate semStaticInvokeArg / isStaticValue helpers from semtypes.nim. Also fold const arrays against their array type when binding to static[openArray[T]], so `SizedBox[shape]` canonicalizes like `SizedBox[[…]]`. Report constraint mismatches (with concept missing: detail) at the argument site via genericArgErrorMsg, matching routine diagnostics. Tests: type-position openArray cases in tstaticparams; new errmsgs companion tstaticopenarraytype; update tstaticparamruntime and tsubscriptstaticgeneric .msgs for unified wording. Fixes #2549
Sem, bind and canonical emission of each type-instantiation argument now happen in a single loop over the generic parameters instead of sem-all, then match-all over the half-built `dest`, then a third walk to rebuild the canonical args (plus a fourth to count parameters). The per-argument logic is factored out as `matchExplicitGenericArg`, shared with routine overload resolution; `buildCanonicalGenericArgs` is gone. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.