fixes #537; fixes invalid file causes crashing #550
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
reviewed
Feb 14, 2025
src/nifc/codegen.nim
Outdated
| if pool.files.hasId(file): | ||
| write stdout, pool.files[file] | ||
| else: | ||
| write stdout, "???" |
There was a problem hiding this comment.
No, if the info.isValid it should be valid line information, the error happens earlier, when the line information is created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #537
I'm not sure about the meaning of an empty filename in the line info. I suppose it is unintentional, instead of meaning the current filename.
It gives a proper error:
???(4, 5) [Error] expected top level construct but got: "foo.nim"