[#50] As a developer, I can use String extensions in effective way#51
Merged
hoangnguyen92dn merged 3 commits intochore/52-migrate-build-files-to-kotlin-dslfrom Dec 17, 2025
Conversation
eeeeaa
reviewed
Feb 13, 2025
common-ktx/src/main/java/co/nimblehq/common/extensions/StringExt.kt
Outdated
Show resolved
Hide resolved
common-ktx/src/main/java/co/nimblehq/common/extensions/StringExt.kt
Outdated
Show resolved
Hide resolved
Member
|
@hoangnguyen92dn Can we push this contribution to be ready and deliver soon? 🚀 |
hoangnguyen92dn
force-pushed
the
chore/50-add-contract-to-string-extensions
branch
from
7281ed0 to
de023ea
Compare
hoangnguyen92dn
changed the base branch from
develop
to
chore/52-migrate-build-files-to-kotlin-dsl
RxJavaTemplate Jacoco report:Generated by 🚫 Danger |
eeeeaa
approved these changes
Dec 16, 2025
luongvo
approved these changes
Dec 16, 2025
thawzintoe-ptut
approved these changes
Dec 16, 2025
hoangnguyen92dn
merged commit f8c4b12
into
chore/52-migrate-build-files-to-kotlin-dsl
2 of 3 checks passed
hoangnguyen92dn
deleted the
chore/50-add-contract-to-string-extensions
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#50
What happened 👀
Add
contract {}in these 2 extensions:String?.isNotNullOrEmpty()String?.isNotNullOrBlank()Insight 📝
Explained the reason why we need to add
contract {}in issue #50Proof Of Work 📹
CI ✅