HTTP/1.1: Reject non-token characters in header names - #1721
Open
lalalala5678 wants to merge 1 commit into
Open
Conversation
RFC 9110 defines field-name as token. Previously Cowboy only rejected whitespace, CR, LF and NUL bytes in header names and accepted all other bytes. Any byte that is not a valid token character is now rejected with a 400 status code and the connection is closed, like other parse errors. This change was requested by the maintainer following a report.
Author
|
CI note: the failing jobs are unrelated to this change. They are (1) a Windows pacman mirror failure downloading ca-certificates (tests never started), and (2) timing-sensitive flakes in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 9110 defines
field-name = token. Previously Cowboy only rejected whitespace, CR, LF and NUL bytes in header field names and accepted all other bytes (control characters, separators, high bytes) via the catch-all clause inparse_hd_name/4.This adds the
when ?IS_TOKEN(C)guard on the accepting clause, as you suggested by email following my report. Any byte that is not a valid token character is now rejected with a 400 status code and the connection is closed, matching the existing parse error handling (same mechanism as the NUL byte clause). The specific error clauses for whitespace, CR/LF and NUL still fire with their dedicated reasons.A test is added to
rfc7230_SUITEcovering control characters, separators, high bytes, an invalid first character and an invalid character immediately before the colon. Fullmake ctrun: rfc7230_SUITE 158/158 ok; no regressions elsewhere (the only failures arestatic_handler_SUITE:dir_error_unreadable, which fails when the test suite runs as root, and intermittent timing-sensitivesys_SUITEcases — both reproduce on unmodified master).