Skip to content

fix: automatically trace package aliases from package.json #3361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: automatically trace package aliases from package.json #3361

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 30 additions & 7 deletions src/build/plugins/externals.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,33 @@ export function externals(opts: NodeExternalsOptions): Plugin {
}
}

const userPkg = await readPackageJSON(
opts.rootDir || process.cwd()
).catch(() => ({}) as PackageJson);

const userPkgAliases = Object.fromEntries(
[
...Object.entries(userPkg.dependencies || {}),
...Object.entries(userPkg.devDependencies || {}),
]
.map(([name, version]) => {
// TODO: optimize this package name parsing
// { "lodash4": "npm:[email protected]" } => [ "lodash" ~> "lodash4" ]
// { "@std/ulid": "npm:@jsr/[email protected]" } => [ "@jsr/std__ulid" ~> "@std/ulid" ]

if (!version.includes(":")) {
return null;
}

const parts = version.split(":")[1]!.split("@");
return parts.length >= 3
? ["@" + parts[1], name]
: [parts[0], name];
})
.filter(Boolean) as [string, string][]
);

const pkgAliases = { ...userPkgAliases, ...opts.traceAlias };
const usedAliases: Record<string, string> = {};

const writePackage = async (
Expand Down Expand Up @@ -340,9 +367,9 @@ export function externals(opts: NodeExternalsOptions): Plugin {
);

// Link aliases
if (opts.traceAlias && pkgPath in opts.traceAlias) {
usedAliases[opts.traceAlias[pkgPath]] = version;
await linkPackage(pkgPath, opts.traceAlias[pkgPath]);
if (pkgPath in pkgAliases) {
usedAliases[pkgAliases[pkgPath]] = version;
await linkPackage(pkgPath, pkgAliases[pkgPath]);
}
};

Expand Down Expand Up @@ -457,10 +484,6 @@ export function externals(opts: NodeExternalsOptions): Plugin {
}

// Write an informative package.json
const userPkg = await readPackageJSON(
opts.rootDir || process.cwd()
).catch(() => ({}) as PackageJson);

await writePackageJSON(resolve(opts.outDir, "package.json"), {
name: (userPkg.name || "server") + "-prod",
version: userPkg.version || "0.0.0",
Expand Down