fix(static): only add vary response header when serving public assets if compression is enabled #3521
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
#3501
β Type of change
π Description
This PR aims to fix the current implementation of the
varyresponse header from the nitro server.Right now, every request that includes the
accept-encodingheader will get back a response withvary: accept-encodingdespite nitro not serving different content. This should only happen when nitro serves different compressed (on build time) versions of public assets (when thecompressPublicAssetsconfig option is enabled).This PR fixes that and also handles this other related issue #3077, where the vary header is wrongly omitted if the encoding request header is not sent (or if set to a different value than the ones supported by EncodingMap) for compressed assets.
π Checklist