feat: export preset types from nitro/types #3646
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Re-export PresetName, PresetNameInput, PresetOptions in src/types/preset.ts
- Add @cloudflare/workers-types to externals to fix build error
Users can now import preset types:
import type { PresetName, PresetOptions, PresetNameInput } from 'nitro/types'
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>
|
@productdevbook is attempting to deploy a commit to the Nitro Team on Vercel. A member of the Team first needs to authorize it. |
- Re-export PresetName, PresetNameInput, PresetOptions in src/types/preset.ts
- Add @cloudflare/workers-types to externals to fix build error
- Add src/presets/index.ts to build entries
- Add nitro/presets export path to package.json
Users can now import preset types from nitro/types:
import type { PresetName, PresetOptions, PresetNameInput } from 'nitro/types'
Or from nitro/presets (for backward compatibility):
import type { PresetName, PresetOptions, PresetNameInput } from 'nitro/presets'
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>
productdevbook
force-pushed
the
feat/export-preset-name-type
branch
from
9a28d53 to
52be0f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR exports preset types (
PresetName,PresetNameInput,PresetOptions) fromnitro/typesmaking them available for TypeScript users.Changes
PresetName,PresetNameInput, andPresetOptionsinsrc/types/preset.ts@cloudflare/workers-typesto externals to fix build error with rollup-plugin-dtsUsage
After this change, users can import preset types directly:
Motivation
Currently, these types are generated in
src/presets/_types.gen.tsbut are not accessible through any public export path. Users need these types to:Note
PresetOptionsis already available viaNitroOptions(which extends it), but this PR makes it directly accessible alongside the other preset types for convenience.Testing
pnpm builddist/types/index.d.mts