Skip to content

CONTRIBUTING.md: Require author != resource creator#340

Open
cyntheticfox wants to merge 1 commit into
nix-community:mainfrom
cyntheticfox:patch/author-requirement
Open

CONTRIBUTING.md: Require author != resource creator#340
cyntheticfox wants to merge 1 commit into
nix-community:mainfrom
cyntheticfox:patch/author-requirement

Conversation

@cyntheticfox
Copy link
Copy Markdown
Member

Require the author of the pull request to not be the creator or primary maintainer of the proposed resource, to reduce the likelihood of author conflict-of-interest.

Also added a construction-worker emoji since I felt whimsical today.

See also #334

I'm not saying a resource submitted by resource creator can't be awesome, but it's harder to judge if it is if the author of the PR stands to potentially directly benefit in opening it.

This comes after a lot of self-promotion of resources, and sort of acts as a two-person control.

It isn't retro-active, but self-promotion does colour the perspective of the review

Require the author of the pull request to not be the creator or primary
maintainer of the proposed resource, to reduce the likelihood of
author conflict-of-interest.

See also nix-community#334
@Zellrus
Copy link
Copy Markdown

Zellrus commented May 22, 2026

Does the new rule apply retroactively? In other words, will it be applied to people who have already submitted a pull request for their project? Am I understanding correctly that because of this, my website will not be able to get into the awesome list?

I don’t know English, so I’m translating this with the help of AI. Sorry for any mistakes.

@cyntheticfox
Copy link
Copy Markdown
Member Author

Does the new rule apply retroactively? In other words, will it be applied to people who have already submitted a pull request for their project? Am I understanding correctly that because of this, my website will not be able to get into the awesome list?

I don’t know English, so I’m translating this with the help of AI. Sorry for any mistakes.

The last line of the PR comment is that it won't apply retroactively, but it may have some influence on the decision to include it. Don't worry about it too much though, since it's more about what the resource provides, how it does it, and how influential it is than who's submitting the PR 🙂

@giomf
Copy link
Copy Markdown

giomf commented May 27, 2026

As the author of a package, I also opened a pull request (#328 ). Since I believe my package adds value, I wanted to share it.

I understand the basic idea, but I’m not sure if this is the right mechanism. What if the repository had to have at least 50 stars before a pull request could be accepted? It’s just too easy to ask a coworker or friend to open a pull request here. I don’t think that would really be a hindrance.

@pinage404
Copy link
Copy Markdown
Contributor

Having 50 stars is (relatively) easy on Github but harder to get on others forges

@giomf
Copy link
Copy Markdown

giomf commented May 27, 2026

My point was that the number of stars—whatever that number may be—shows more clearly that a community is interested, and so, in my opinion, it is the better tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants