Add support for multiple NixOS system profiles#541
Open
leguteape wants to merge 3 commits into
Open
Conversation
Member
|
@rv32ima can I let you do a first pass? Then ping me and I will do another pass so we can get that promptly merged. |
leguteape
force-pushed
the
master
branch
4 times, most recently
from
25a3a2b to
484948c
Compare
nikstur
requested changes
Apr 10, 2026
| ++ cfg.extraEfiSysMountPoints; | ||
|
|
||
| mkInstallCommand = efiSysMountPoint: '' | ||
| prof_dir="/nix/var/nix/profiles" profiles="" |
Member
There was a problem hiding this comment.
This should definitely not be implemented as a shell script. This needs to be done in the rust code
This comment was marked as low quality.
This comment was marked as low quality.
Sorry, something went wrong.
Author
There was a problem hiding this comment.
Hey. Thanks for your suggestion! I am willing to rewrite this in Rust but I would appreciate some pointers regarding where to implement this functionality. If you could suggest the file/files for storing this code, that would be quite helpful.
- Make profile name available in bootmenu entries to aid identification - Also add profile name to .efi files in `EFI/Linux` - Handle cases where profile name is not specified by falling back to `system-*-link`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey everyone. This PR attempts to add support for NixOS system profiles to lanzaboote. I had originally written this patch at around August of 2025 for personal use but the folks over at #135 have encouraged me to create a PR here.
Here's a list of the most important changes:
system-profiles/while also being compatible with non-profiled systems-characters, handle any stray-s so versions and profile names can be safely extracted.efientries as well as in boot menus in a fashion consistent withsystemd-bootI must add that I didn't know any Rust and sorta hacked my way around when I made these changes, following compiler hints and warnings. So, the quality of the my modifications may not be the best. I would, hence, be welcoming of any suggestions aimed towards improving the quality of this patch.
P.S. Here's an image of what the boot menu looks like after my changes (profile names are inside square brackets):
systemprofile.WorkstationprofileGamestationprofile