Skip to content

Use line based diff instead of character based #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SuperSandro2000 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use line based diff instead of character based #205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/cmd/review.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ use std::{
use dialoguer::{console::Term, theme::ColorfulTheme, Select};
use eyre::{eyre, Result};
use owo_colors::OwoColorize;
use similar::{ChangeTag, TextDiff};
use similar::{Algorithm, ChangeTag, TextDiff};

use crate::{
cfg::Config,
Expand Down Expand Up @@ -94,7 +94,7 @@ pub fn review(opts: Opts, cfg: Option<Config>) -> Result<()> {
}

fn print_diff(fmt: &'static str, old: &str, new: &str) -> Result<()> {
let diff = TextDiff::from_graphemes(old, new);
let diff = TextDiff::configure().algorithm(Algorithm::Patience).diff_lines(old, new);
for change in diff.iter_all_changes() {
let tag = change.tag();
let change = change.to_string_lossy();
Expand Down