modules/lsp/server: declare package defaults
#3243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
MattSturgeon
force-pushed
the
lsp-packages
branch
from
262ae92 to
b0a06d8
Compare
MattSturgeon
commented
Apr 29, 2025
MattSturgeon
force-pushed
the
lsp-packages
branch
from
b0a06d8 to
b281999
Compare
MattSturgeon
changed the title
package defaultspackage defaults
MattSturgeon
force-pushed
the
lsp-packages
branch
from
b281999 to
5450ad7
Compare
MattSturgeon
force-pushed
the
lsp-packages
branch
from
5450ad7 to
03fc6bd
Compare
GaetanLepage
approved these changes
Apr 30, 2025
Member
GaetanLepage
left a comment
GaetanLepage
left a comment
There was a problem hiding this comment.
LGTM, well done @MattSturgeon !
khaneliman
reviewed
Apr 30, 2025
MattSturgeon
commented
Apr 30, 2025
Convert the `attrsOf (servers.nix)` option to a freeform submodule. Declare a `servers.nix` option for each lsp server listed in `lsp-packages.nix` that has a known nixpkgs package.
MattSturgeon
force-pushed
the
lsp-packages
branch
from
03fc6bd to
e34eaf8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
|
This pull request, with head sha This pull request will be automatically closed by GitHub.As soon as GitHub detects that the sha It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial design for declaring per-server
lsp.servers.<name>.packagedefaults.lsp.serversto a freeform submoduleserver.nixmodule usinglib.importApplylsp.servers.<name>option for each packaged server