plugins/substitute: added plugin #4010
Conversation
|
Thank you for the quick response! I have changed the code as per your suggestions :) |
|
Good catch, changed it so that aligns with that now. |
|
Fixed the ... of the inputs, the other comment was already resolved in an older commit. |
|
Thank you, I will do that. How do I request another review to be able to merge? |
|
Since you are not a maintainer yet, you can't request reviews, but I will request for you |
|
Could you have a look at this? @GaetanLepage |
This still needs to be done. Otherwise, LGTM. |
|
I think I squashed the commits now @MattSturgeon |
Sorry for the misunderstanding. There needs to be two commits:
Currently, there is only a single one. |
| settingsExample = { | ||
| on_substitute = lib.nixvim.nestedLiteralLua '' | ||
| function(params) | ||
| vim.notify("substituted using register " .. params.register) | ||
| end | ||
| ''; | ||
|
|
||
| yank_substituted_text = true; | ||
| modifiers = [ | ||
| "join" | ||
| "trim" | ||
| ]; | ||
| highlight_substituted_text.timer = 750; | ||
| range = { | ||
| prefix = "S"; | ||
| complete_word = true; | ||
| confirm = true; | ||
| subject.motion = "iw"; | ||
| range.motion = "ap"; | ||
| suffix = "| call histdel(':', -1)"; | ||
| auto_apply = true; | ||
| cursor_position = "start"; | ||
| }; | ||
| exchange = { | ||
| motion = "ap"; | ||
| use_esc_to_cancel = false; | ||
| preserve_cursor_position = true; | ||
| }; | ||
| }; |
There was a problem hiding this comment.
Nit: Optionally reduce the size of settingsExample as it will make the documentation clearer.
| { | ||
| lib, | ||
| ... | ||
| }: |
There was a problem hiding this comment.
| { | |
| lib, | |
| ... | |
| }: | |
| { lib, ... }: |
nit
plugins/substitute: removed options and used nested plugins/substitute: changed example plugins/substitute: remove __raw plugins/substitute: Fixed failing test plugins/substitute: removedplugins/substitute: init removed
|
Squashed to two commits now @GaetanLepage 👍🏻 |
Commits are in the wrong order. The
Simply drop a few options. I don't think that they are interdependent, are they? |
4 participants
Added support for substitute.nvim.
Added tests and plugin support, and myself as a maintainer.