Add simple template #884
Open
Add simple template #884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmonteiro
reviewed
Jun 19, 2023
templates/simple/src/bin/dune
Outdated
| @@ -0,0 +1,4 @@ | |||
| (executable | |||
| (name main) | |||
| (public_name package) | |||
There was a problem hiding this comment.
very confusing to call everything package. Can we come up with a bit better names?
There was a problem hiding this comment.
Sure, what about just example?
There was a problem hiding this comment.
we could do a library and no executable?
There was a problem hiding this comment.
I kept both but renamed it to example, if that's okay with you it should be good to go now
ulrikstrid
force-pushed
the
ulrikstrid--simple-template
branch
from
3b75f92 to
a57908b
Compare
ulrikstrid
force-pushed
the
ulrikstrid--simple-template
branch
from
a57908b to
99c8a44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.