Fixes last item size when ExpandableCarousel has no padsEnds #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
What does this PR do?
Fixes bugs or issues #48
When last item of ExpandableCarousel is bigger than others and
padsEnds
is false, its bottom is clipped.That's because 2 carousel items are displayed in the same page, and real page index is floored. So when I switch to slide 4,
pageIndex
is 3.75 (or 3.xxx, depending on viewportFraction, padding etc etc). And (3.75).floor() is 3, so if the 3rd item is smaller than the 4th, the 4th is displayed but its size is not large enough.I hope this is clear. You can reproduce with this options in your ExpandableCarousel example :
Checklist
Code Changes
Documentation
pubspec.yaml
fileTesting
General Tests
Autoplay Feature
Indicators and Customization
Looping and Scrolling
Accessibility
Semantics
labels added)Responsiveness
Error Handling
Performance
How did you verify your code works?
flutter test
)