feat: add @nl-design-system/eslint-config #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matijs
force-pushed
the
feat/eslint-config
branch
from
dde9ec2 to
a20e0c1
Compare
matijs
commented
Nov 3, 2024
matijs
force-pushed
the
feat/eslint-config
branch
3 times, most recently
from
f32b83d to
18cfdfe
Compare
matijs
commented
Nov 5, 2024
matijs
force-pushed
the
feat/eslint-config
branch
from
18cfdfe to
7b1cf6b
Compare
matijs
commented
Nov 5, 2024
matijs
commented
Nov 5, 2024
Robbert
reviewed
Nov 6, 2024
matijs
force-pushed
the
feat/eslint-config
branch
from
7b1cf6b to
3a706ab
Compare
Add a new package @nl-design-system/eslint-config and immediately eat our own dogfood by using it in the basis repo itself. eslint-plugin-import was more or less replaced by eslint-plugin-perfectionist that provides similar functionality and more. Rename config files for tools that support importing their config instead of requiring it. Improve lint-staged by running both prettier and eslint (and stylelint) on files that support both.
matijs
force-pushed
the
feat/eslint-config
branch
from
3a706ab to
b106452
Compare
Robbert
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new package @nl-design-system/eslint-config and immediately eat our own dogfood by using it in the basis repo itself.
eslint-plugin-import was more or less replaced by
eslint-plugin-perfectionist that provides similar functionality and more.
Rename config files for tools that support importing their config instead of requiring it.
Improve lint-staged by running both prettier and eslint (and stylelint) on files that support both.