Skip to content

Commit

Permalink
style(link): links with external icon (always after the label) to inl… (
Browse files Browse the repository at this point in the history
#1678)

Closing multiple old www-denhaag-nl branches;

closes #1675 #1674 #1672 #1620 #1602 #1631 #1587 #1659 #1628
  • Loading branch information
paulAcato authored Feb 13, 2025
1 parent a74e12d commit b80ce6b
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 34 deletions.
9 changes: 9 additions & 0 deletions components/Link/src/index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,15 @@
}
}

.denhaag-link:has(.denhaag-link__label ~ .denhaag-icon),
.denhaag-link--external:has(.denhaag-link__label ~ .denhaag-icon) {
display: inline;

.denhaag-icon {
margin-inline-start: var(--denhaag-link-icon-gap, var(--denhaag-space-2xs));
}
}

.denhaag-link--disabled,
.denhaag-link--disabled--hover,
.denhaag-link--disabled:hover {
Expand Down
36 changes: 2 additions & 34 deletions components/LinkGroup/src/stories/bem.stories.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -83,23 +83,6 @@ import readme from "../../README.md";
href="https://nl-design-system.github.io/denhaag/"
className="denhaag-link denhaag-link--with-icon denhaag-link--with-icon-start"
>
<svg
width="1em"
height="1em"
viewBox="0 0 24 24"
fill="none"
xmlns="http://www.w3.org/2000/svg"
className="denhaag-icon"
focusable="false"
aria-hidden="true"
shapeRendering="auto"
>
<path
d="M12.293 5.293a1 1 0 011.414 0l6 6a1 1 0 010 1.414l-6 6a1 1 0 01-1.414-1.414L16.586 13H5a1 1 0 110-2h11.586l-4.293-4.293a1 1 0 010-1.414z"
fill="currentColor"
></path>
</svg>
<span className="denhaag-link__label">Inburgeren en naturaliseren</span>
<svg
width="1em"
height="1em"
Expand All @@ -116,6 +99,7 @@ import readme from "../../README.md";
fill="currentColor"
></path>
</svg>
<span className="denhaag-link__label">Inburgeren en naturaliseren</span>
</a>
</li>
<li className="denhaag-link-group__list-item">
Expand Down Expand Up @@ -219,23 +203,6 @@ import readme from "../../README.md";
href="https://nl-design-system.github.io/denhaag/"
className="denhaag-link denhaag-link--with-icon denhaag-link--with-icon-start"
>
<svg
width="1em"
height="1em"
viewBox="0 0 24 24"
fill="none"
xmlns="http://www.w3.org/2000/svg"
className="denhaag-icon"
focusable="false"
aria-hidden="true"
shapeRendering="auto"
>
<path
d="M12.293 5.293a1 1 0 011.414 0l6 6a1 1 0 010 1.414l-6 6a1 1 0 01-1.414-1.414L16.586 13H5a1 1 0 110-2h11.586l-4.293-4.293a1 1 0 010-1.414z"
fill="currentColor"
></path>
</svg>
<span className="denhaag-link__label">Parkeerplaats voor huisartsen en verloskundigen</span>
<svg
width="1em"
height="1em"
Expand All @@ -252,6 +219,7 @@ import readme from "../../README.md";
fill="currentColor"
></path>
</svg>
<span className="denhaag-link__label">Parkeerplaats voor huisartsen en verloskundigen</span>
</a>
</li>
</ul>
Expand Down

0 comments on commit b80ce6b

Please sign in to comment.