Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add open forms component stories #1426

Merged
merged 8 commits into from
Jan 19, 2024
Merged

feat: add open forms component stories #1426

merged 8 commits into from
Jan 19, 2024

Conversation

bddjong
Copy link
Contributor

@bddjong bddjong commented Jan 15, 2024 •
edited
Loading

Adds open forms components to storybook.

Components to add

  • BSN field
  • Checkbox
  • Columns
  • Content
  • Cosign
  • Currency
  • DateTimeField
  • Datefield
  • TextField
  • EditGrid (Repeating group)
  • Email
  • FieldSet
  • IBANField
  • LicensePlateField
  • Number
  • PhoneNumberField
  • Radio
  • Select
  • Selectboxes
  • Signature
  • Textarea
  • TimeField

@vercel Vercel
Copy link

vercel bot commented Jan 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
denhaag ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2024 11:02pm

@bddjong bddjong changed the title feat: add open forms component util feat: add open forms component stories Jan 17, 2024
@bddjong bddjong force-pushed the feat/add-open-forms-components branch from f3adfbd to cd95b76 Compare January 17, 2024 01:14
@bddjong bddjong marked this pull request as ready for review January 17, 2024 01:14
@bddjong bddjong requested a review from Robbert January 17, 2024 08:43
@bddjong
Copy link
Contributor Author

bddjong commented Jan 17, 2024

Theres a few components that require a bit more digging or configuration. For example the map component. As well as Open Forms layout react components such as the progress indicators, buttons and toolbars.

@bddjong bddjong force-pushed the feat/add-open-forms-components branch from 09c70bd to 198a92e Compare January 17, 2024 09:11
@bddjong bddjong force-pushed the feat/add-open-forms-components branch from 198a92e to 4f91d88 Compare January 17, 2024 09:16
@bddjong bddjong force-pushed the feat/add-open-forms-components branch from 6dafc07 to fe7c93d Compare January 17, 2024 09:59
@bddjong
Copy link
Contributor Author

bddjong commented Jan 17, 2024

Refactored to move the FormIO configuration into a hook for the RenderFormioForm component

@bddjong bddjong mentioned this pull request Jan 17, 2024
Open
@bddjong bddjong requested a review from Robbert January 17, 2024 14:21
YourivHDenHaag
YourivHDenHaag approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@YourivHDenHaag YourivHDenHaag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ziet er goed uit, thanks!

@bddjong bddjong force-pushed the feat/add-open-forms-components branch from fe7c93d to b71f1a4 Compare January 18, 2024 22:54
@bddjong bddjong merged commit d7bb890 into main Jan 19, 2024
7 of 8 checks passed
@bddjong bddjong deleted the feat/add-open-forms-components branch January 19, 2024 08:49
@bddjong bddjong mentioned this pull request Feb 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robbert Robbert Robbert approved these changes

@YourivHDenHaag YourivHDenHaag YourivHDenHaag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bddjong @Robbert @YourivHDenHaag