Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Link component override #1441

Merged
merged 5 commits into from
Jan 31, 2024

Conversation

YourivHDenHaag
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Jan 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
denhaag ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 1:14pm

Copy link
Member

@Yolijn Yolijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ziet er super goed uit! Alleen die lock-file moet er denk ik niet bij?

@Robbert
Copy link
Member

Robbert commented Jan 30, 2024

For reference, this is our approach for similar golas in a project for gemeente Utrecht:
https://github.com/frameless/strapi/blob/main/packages/ui/src/components/AdvancedLink/index.tsx

@YourivHDenHaag YourivHDenHaag requested a review from Borai January 31, 2024 12:33
@YourivHDenHaag YourivHDenHaag marked this pull request as ready for review January 31, 2024 12:34
@YourivHDenHaag
Copy link
Contributor Author

Ziet er super goed uit! Alleen die lock-file moet er denk ik niet bij?

@Yolijn Geen idee wat daar precies gebeurd is. Wanneer ik pnpm install doe krijg ik dezelfde lock file.

@YourivHDenHaag YourivHDenHaag requested a review from Yolijn January 31, 2024 12:37
@YourivHDenHaag YourivHDenHaag merged commit d1671f6 into main Jan 31, 2024
8 checks passed
@YourivHDenHaag YourivHDenHaag deleted the fix/override_link_with_other_component branch January 31, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants