Repository navigation
feat: introduce basis tokens in figma.tokens.json - #2889
Draft
bartveneman wants to merge 27 commits into
Draft
bartveneman wants to merge 27 commits into
bartveneman wants to merge 27 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 3023243 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bartveneman
marked this pull request as draft
October 23, 2026 09:03
bartveneman
force-pushed
the
feat/introduce-basis-tokens
branch
from
October 23, 2026 09:10
4e5135f to
c458ee6
Compare
bartveneman
force-pushed
the
feat/introduce-basis-tokens
branch
from
October 23, 2026 10:08
c458ee6 to
e72e799
Compare
bartveneman
marked this pull request as ready for review
October 23, 2026 11:21
Robbert
marked this pull request as draft
October 23, 2026 12:10
bartveneman
commented
Oct 23, 2026
| '@rijkshuisstijl-community/design-tokens': minor | ||
| --- | ||
|
|
||
| feat: introduce Basis tokens (without making actual theme changes yet) |
Contributor
Author
There was a problem hiding this comment.
todo: nog updaten voordat de PR ready4review is
Where it started:
```
• rhc.focus.outline-offset: Invalid token reference: $type "other" of "{"$type":"other","$value":"{rhc.space.xs}"}" at "rhc.focus.outline-offset" does not match the $type on reference {rhc.space.xs}. Types "other" and "dimension" do not match.
• rhc.logo.subtitle.letter-spacing: Invalid token reference: $type "letterSpacing" of "{"$type":"letterSpacing","$value":"{rhc.text.letter-spacing.tight}"}" at "rhc.logo.subtitle.letter-spacing" does not match the $type on reference {rhc.text.letter-spacing.tight}. Types "letterSpacing" and "dimension" do not match.
• rhc.logo.title.letter-spacing: Invalid token reference: $type "letterSpacing" of "{"$type":"letterSpacing","$value":"{rhc.text.letter-spacing.normal}"}" at "rhc.logo.title.letter-spacing" does not match the $type on reference {rhc.text.letter-spacing.normal}. Types "letterSpacing" and "dimension" do not match.
• rhc.message-list.item.label.font-family: Invalid token reference: $type "font-family" of "{"$type":"font-family","$value":"{rhc.text.font-family.default}"}" at "rhc.message-list.item.label.font-family" does not match the $type on reference {rhc.text.font-family.default}. Types "font-family" and "fontFamily" do not match.
• rhc.message-list.item.label.font-size: Invalid token reference: $type "font-size" of "{"$type":"font-size","$value":"{rhc.text.font-size.md}"}" at "rhc.message-list.item.label.font-size" does not match the $type on reference {rhc.text.font-size.md}. Types "font-size" and "dimension" do not match.
• rhc.message-list.item.label.font-weight: Invalid token reference: $type "font-weight" of "{"$type":"font-weight","$value":"{rhc.text.font-weight.strong}"}" at "rhc.message-list.item.label.font-weight" does not match the $type on reference {rhc.text.font-weight.strong}. Types "font-weight" and "number" do not match.
• rhc.message-list.item.label.line-height: Invalid token reference: $type "line-height" of "{"$type":"line-height","$value":"{rhc.text.line-height.md}"}" at "rhc.message-list.item.label.line-height" does not match the $type on reference {rhc.text.line-height.md}. Types "line-height" and "number" do not match.
• utrecht.focus.outline-offset: Invalid token reference: $type "dimension" of "{"$type":"dimension","$value":"{rhc.focus.outline-offset}"}" at "utrecht.focus.outline-offset" does not match the $type on reference {rhc.focus.outline-offset}. Types "dimension" and "other" do not match.
• utrecht.link.text-underline-offset: Invalid token reference: $type "other" of "{"$type":"other","$value":"{rhc.space.xs}","$description":"[code-only]"}" at "utrecht.link.text-underline-offset" does not match the $type on reference {rhc.space.xs}. Types "other" and "dimension" do not match.
• utrecht.listbox.font-weight: Invalid token reference: $type "dimension" of "{"$type":"dimension","$value":"{rhc.text.font-weight.regular}"}" at "utrecht.listbox.font-weight" does not match the $type on reference {rhc.text.font-weight.regular}. Types "dimension" and "number" do not match.
• todo.accordion.button.line-height: Invalid token reference: $type "lineHeight" of "{"$type":"lineHeight","$value":"{utrecht.button.subtle.line-height}","$extensions":{"nl.nldesignsystem.token-subtype":"line-height"}}" at "todo.accordion.button.line-height" does not match the $type on reference {utrecht.button.subtle.line-height}. Types "lineHeight" and "dimension" do not match.
• nl.link.text-underline-offset: Invalid token reference: $type "other" of "{"$type":"other","$value":"{rhc.space.xs}","$description":"[code-only]"}" at "nl.link.text-underline-offset" does not match the $type on reference {rhc.space.xs}. Types "other" and "dimension" do not match.
• ams.pagination.link.text-underline-offset: Invalid token reference: $type "other" of "{"$type":"other","$value":"{rhc.space.xs}","$description":"[code-only]"}" at "ams.pagination.link.text-underline-offset" does not match the $type on reference {rhc.space.xs}. Types "other" and "dimension" do not match.
• basis.color.default.border-default.$value: Insufficient contrast
• basis.color.default.bg-default.$value: Insufficient contrast
• basis.color.highlight.color-default.$value: Insufficient contrast
• basis.color.highlight.bg-default.$value: Insufficient contrast
• rhc.logo.title.min.font-size.$value: Font-size should be 14px or 0.875rem minimum (got: "0.75rem")
• utrecht.button.primary-action.line-height.$value: Line-height should be a unitless number (got: {"unit":"rem","value":1.875})
• utrecht.button.secondary-action.line-height.$value: Line-height should be a unitless number (got: {"unit":"rem","value":1.875})
• utrecht.button.subtle.line-height.$value: Line-height should be a unitless number (got: {"unit":"rem","value":1.875})
• utrecht.form-field-error-message.line-height.$value: Line-height should be a unitless number (got: {"unit":"normal","value":0})
```
Where it's at:
```
• basis.color.default.border-default.$value: Insufficient contrast
• basis.color.default.bg-default.$value: Insufficient contrast
• basis.color.highlight.color-default.$value: Insufficient contrast
• basis.color.highlight.bg-default.$value: Insufficient contrast
• rhc.logo.title.min.font-size.$value: Font-size should be 14px or 0.875rem minimum (got: "0.75rem")
```
…anje and cool-grey
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
common.basisobject infigma.tokens.jsonwith all the basis tokens from the Start-theme (commit #1)color.action-2fromaccent-1toaction-1(commit #2)closes #2888
blocked by #2890