Fix design token syntax issues and upgrade to Style Dictionary 5 - #1395
Open
richadr wants to merge 19 commits into
Open
Fix design token syntax issues and upgrade to Style Dictionary 5#1395richadr wants to merge 19 commits into
richadr wants to merge 19 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
2 tasks
richadr
force-pushed
the
build/test-command-exit-1
branch
from
April 28, 2026 12:41
4240c7a to
656129f
Compare
|
Robbert
previously approved these changes
Jul 16, 2026
Robbert
self-requested a review
July 16, 2026 16:11
richadr
marked this pull request as draft
July 21, 2026 10:06
Robbert
removed their request for review
August 10, 2026 15:27
This prevents silent `pnpm test` failures; it should block the pipeline instead.
…g the group itself
richadr
force-pushed
the
build/test-command-exit-1
branch
from
August 12, 2026 07:09
656129f to
60689ef
Compare
This release contains [breaking changes](https://github.com/style-dictionary/style-dictionary/blob/main/CHANGELOG.md#500) like not allowing the .value suffix, which has been fixed in earlier commits
|
richadr
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1395 +/- ##
=======================================
Coverage 89.51% 89.51%
=======================================
Files 19 19
Lines 1392 1392
Branches 185 174 -11
=======================================
Hits 1246 1246
Misses 145 145
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Robbert
requested changes
Aug 12, 2026
| "test": "npm-run-all test-workspaces test-build:**", | ||
| "test-build:css": "find proprietary/*/dist -type d \\( -name node_modules \\) -prune -false -o -name '*.css' -print0 -exec sass --no-source-map {}:/dev/null \\;", | ||
| "test-build:scss": "find proprietary/*/dist -type d \\( -name node_modules \\) -prune -false -o -name '*.scss' -print0 -exec sass --no-source-map {} \\;", | ||
| "test": "pnpm run test-workspaces && pnpm run test-build:css && pnpm run test-build:scss", |
Member
There was a problem hiding this comment.
De bedoeling van pnpm run test-build is om juist separate te zijn van pnpm run test.
Ik denk dat we dit ergens in het handboek moeten gaan documenteren, als we dat niet al hebben.
pnpm run test: draai alle test die mogelijk zijn zonder te wachten oppnpm run build, voor snelle feedback in CIpnpm run test-build: draai alle test die pas mogelijk zijn nápnpm run build
Robbert
requested changes
Aug 12, 2026
Member
There was a problem hiding this comment.
Hoe zeker weten we dat het een minor is en niet major?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
pnpm testoutputs a list of issues, but the pipeline is not blocked by them. By changing the package.json command, the pipeline will now fail if there is an issue.So that surfaces a couple of issues, which are also fixed in this PR.
Some tokens were not referenced correctly (for example missing braces)
There was a very hard to find ordering bug that was supposedly fixed in Style Dictionary 4.1.2 but properly fixed in 5.1.1 (issue). Upgrading fixes values being referenced before they are declared. So this requires a major upgrade of Style Dictionary.
In Style Dictionary 5, referencing with
.valuesuffix is no longer allowed, this has been removed where needed. The SD5 upgrade was done across the board, and will minor-bump every *-design-tokens package. Other breaking changes are not relevant for us.