WIP: Sittard-Geleen design tokens - #1532
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
efe2cb9 to
042c45b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1532 +/- ##
=======================================
Coverage 89.51% 89.51%
=======================================
Files 19 19
Lines 1392 1392
Branches 185 174 -11
=======================================
Hits 1246 1246
Misses 145 145
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
042c45b to
7a32e50
Compare
7a32e50 to
4be98fa
Compare
4be98fa to
52d3a44
Compare
|
There was a problem hiding this comment.
Zou deze niet toevoegen aan de repo.
| @@ -0,0 +1 @@ | |||
| # Color | |||
There was a problem hiding this comment.
Ben je deze vergeten in te vullen?
| "$extensions": { | ||
| "nl.nldesignsystem.theme-wizard.color-scale-seed-color": { | ||
| "colorSpace": "srgb", | ||
| "components": [ | ||
| 0.13333333333333333, | ||
| 0.4588235294117647, | ||
| 0.6470588235294118 | ||
| ], | ||
| "alpha": 1 | ||
| } | ||
| }, |
There was a problem hiding this comment.
Note to self: design-tokens-schema + theme-wizard zouden ook deze extension moeten verwijderen.
| "name": "accent-1", | ||
| "attributes": {}, | ||
| "path": [ | ||
| "basis", | ||
| "color", | ||
| "accent-1" | ||
| ] |
There was a problem hiding this comment.
Ook dit moet de theme-wizard verwijderen uit je JSON
| "form-control": { | ||
| "font-family": { | ||
| "$type": "fontFamily", | ||
| "$value": "\"Roobert\"" |
There was a problem hiding this comment.
Had verwacht dat dit {basis.heading.font-family} zou zijn? Weet ik overigens niet zeker.
| "font-family": { | ||
| "default": { | ||
| "$type": "fontFamily", | ||
| "$value": "\"Roobert\"" |
There was a problem hiding this comment.
Ja, nu weet ik zeker dat basis.form-control.font-family hiernaar zou moeten verwijzen.
3 participants
WIP sittard-geleen tokens
Sittard-geleen theme toegevoegd