docs: add utrecht note to themes and visual regression - #1554
Open
eslook wants to merge 3 commits into
Open
Conversation
Part of issue nl-design-system/documentatie#4466 Default story from https://github.com/nl-design-system/utrecht/blob/68aa7746c7bcd2445f7b240a851db6eafed97b84/packages/storybook-css/src/Note.stories.tsx Tokens from https://github.com/nl-design-system/utrecht/blob/68aa7746c7bcd2445f7b240a851db6eafed97b84/proprietary/design-tokens/src/component/utrecht/note.tokens.json Mini cleanup task: missing prefix in three stories in component-stories-utrecht.tsx
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
eslook
enabled auto-merge (squash)
August 13, 2026 13:26
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1554 +/- ##
=======================================
Coverage 89.51% 89.51%
=======================================
Files 19 19
Lines 1392 1392
Branches 185 128 -57
=======================================
Hits 1246 1246
- Misses 145 146 +1
+ Partials 1 0 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of issue nl-design-system/documentatie#4466
Default story from https://github.com/nl-design-system/utrecht/blob/68aa7746c7bcd2445f7b240a851db6eafed97b84/packages/storybook-css/src/Note.stories.tsx
Tokens from https://github.com/nl-design-system/utrecht/blob/68aa7746c7bcd2445f7b240a851db6eafed97b84/proprietary/design-tokens/src/component/utrecht/note.tokens.json
Mini cleanup task: missing prefix in three stories in component-stories-utrecht.tsx
Hoe review je dit:
Deze PR heeft deze stap doorlopen: "Component beschikbaar voor visuele regressietests" https://nldesignsystem.nl/handboek/estafettemodel/componenten/community/voor-organisaties/#component-beschikbaar-voor-visuele-regressietests
Je kan het stappenplan doorlopen, controleren dat de wijzigingen inderdaad in de PR staan, en in de UI Test kijken of inderdaad de Utrecht Note er tussen staat.
Kleine disclaimer: de Utrecht Note met het Voorbeeld Thema ziet er nog unstyled uit, omdat die volgende week word opgepakt door designers. Dit is naar verwachting.