Skip to content

Conversation

MrSampson
Copy link

The tags for the graphical concordance example were incorrect.

The tags for the graphical concordance example were incorrect.
@tomaarsen
Copy link
Member

I believe this is a proper change. I can't find any situation where e.g. N N N N finds a result, but NOUN NOUN NOUN NOUN has many results in many corpora. Likewise with the 2 other changes. I can't officially review this, but I'd approve this if I could.

This can easily be verified with

>>> import nltk
>>> nltk.app.concordance()

and then filling in e.g. N N N N and NOUN NOUN NOUN NOUN.

Paging @stevenbird

Following thorugh the book, checking for VBD or VBN in cfd1 is not possible, because it is based on the universal tagset. cfd1 has to recalculated using the WSJ tagset.
In order to get the presented output words of length 3 also have to be included.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants