-
Notifications
You must be signed in to change notification settings - Fork 4
Use heed nested rtxns #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Kerollmops
wants to merge
11
commits into
main
Choose a base branch
from
use-heed-nested-rtxns
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9fec02b to
7b66110
Compare
7b66110 to
910ea1d
Compare
* lifetime and roaring doc * Update src/roaring.rs * lifetime and roaring * Update src/lib.rs --------- Co-authored-by: Nate Nethercott <[email protected]>
910ea1d to
ba4d6c1
Compare
50c9119 to
c5c4c76
Compare
c5c4c76 to
1df20dc
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is enabling Hannoy to utilize the new nested read transactions feature, allowing Meilisearch to build with it as well. We have seen significant improvements when it is necessary to read uncommitted changes in parallel.
I bumped hannoy to v0.0.9-nested-rtxns and would like to release this pre-version on crates.io soon.
Note that this PR is based on #107, as we need both features in Meilisearch. However, as long as #107 is merged into main, we will be able to rebase on it.