Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup initial workflow for building on Windows. #73

Merged
merged 9 commits into from
Feb 13, 2025

Conversation

ScottTodd
Copy link
Member

@ScottTodd ScottTodd commented Feb 6, 2025

Progress on #36.

This adds a new workflow, triggered as part of ci.yml, that configures and builds a subset of the project.

Future changes will:

  • Switch to a more powerful self-hosted runner instead of using standard GitHub-hosted runners (we have some runners but they need some configuration to be able to run the repo tool without SSL: CERTIFICATE_VERIFY_FAILED errors)
  • Build more subprojects (this will patches or upstream changes to each subproject to improve portability)

Comment on lines +71 to +72
- name: Build Projects
run: cmake --build build
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh, more download flakes: https://github.com/nod-ai/TheRock/actions/runs/13190519640/job/36822474141?pr=73#step:11:765

[53/72] Stage installing sub-project therock-eigen
-- Install configuration: "Release"
[54/72] Performing download step (download, verify and extract) for 'therock-FunctionalPlus-sources'
FAILED: third-party/FunctionalPlus/therock-FunctionalPlus-sources_fetch/src/therock-FunctionalPlus-sources-stamp/therock-FunctionalPlus-sources-download D:/a/TheRock/TheRock/build/third-party/FunctionalPlus/therock-FunctionalPlus-sources_fetch/src/therock-FunctionalPlus-sources-stamp/therock-FunctionalPlus-sources-download 
C:\Windows\system32\cmd.exe /C "cd /D D:\a\TheRock\TheRock\build\third-party\FunctionalPlus && "C:\Program Files\CMake\bin\cmake.exe" -DCMAKE_MESSAGE_LOG_LEVEL=VERBOSE -P D:/a/TheRock/TheRock/build/third-party/FunctionalPlus/therock-FunctionalPlus-sources_fetch/src/therock-FunctionalPlus-sources-stamp/download-therock-FunctionalPlus-sources.cmake && "C:\Program Files\CMake\bin\cmake.exe" -DCMAKE_MESSAGE_LOG_LEVEL=VERBOSE -P D:/a/TheRock/TheRock/build/third-party/FunctionalPlus/therock-FunctionalPlus-sources_fetch/src/therock-FunctionalPlus-sources-stamp/verify-therock-FunctionalPlus-sources.cmake && "C:\Program Files\CMake\bin\cmake.exe" -DCMAKE_MESSAGE_LOG_LEVEL=VERBOSE -P D:/a/TheRock/TheRock/build/third-party/FunctionalPlus/therock-FunctionalPlus-sources_fetch/src/therock-FunctionalPlus-sources-stamp/extract-therock-FunctionalPlus-sources.cmake && "C:\Program Files\CMake\bin\cmake.exe" -E touch D:/a/TheRock/TheRock/build/third-party/FunctionalPlus/therock-FunctionalPlus-sources_fetch/src/therock-FunctionalPlus-sources-stamp/therock-FunctionalPlus-sources-download"
-- Downloading...
   dst='D:/a/TheRock/TheRock/build/third-party/FunctionalPlus/therock-FunctionalPlus-sources_fetch/src/v0.2.25.tar.gz'
   timeout='none'
   inactivity timeout='none'
-- Using src='https://github.com/Dobiasd/FunctionalPlus/archive/refs/tags/v0.2.25.tar.gz'
-- Retrying...
-- Using src='https://github.com/Dobiasd/FunctionalPlus/archive/refs/tags/v0.2.25.tar.gz'
-- Retry after 5 seconds (attempt #2) ...
-- Using src='https://github.com/Dobiasd/FunctionalPlus/archive/refs/tags/v0.2.25.tar.gz'
-- Retry after 5 seconds (attempt #3) ...
-- Using src='https://github.com/Dobiasd/FunctionalPlus/archive/refs/tags/v0.2.25.tar.gz'
-- Retry after 15 seconds (attempt #4) ...
-- Using src='https://github.com/Dobiasd/FunctionalPlus/archive/refs/tags/v0.2.25.tar.gz'
-- Retry after 60 seconds (attempt #5) ...
-- Using src='https://github.com/Dobiasd/FunctionalPlus/archive/refs/tags/v0.2.25.tar.gz'
CMake Error at therock-FunctionalPlus-sources_fetch/src/therock-FunctionalPlus-sources-stamp/download-therock-FunctionalPlus-sources.cmake:163 (message):
  Each download failed!

    error: downloading 'https://github.com/Dobiasd/FunctionalPlus/archive/refs/tags/v0.2.25.tar.gz' failed
          status_code: 35
          status_string: "SSL connect error.  If this is due to https certificate verification failure, one may set environment variable CMAKE_TLS_VERIFY=0 to suppress it."
          log:
          --- LOG BEGIN ---
          timeout on name lookup is not supported

  Host github.com:443 was resolved.

@ScottTodd ScottTodd marked this pull request as draft February 7, 2025 20:59
@ScottTodd
Copy link
Member Author

Converting to draft until I can sync and test this. Looks like a few issues popped up. Most recently https://github.com/nod-ai/TheRock/actions/runs/13207156066/job/36872929040?pr=73#step:11:458 FileNotFoundError: [WinError 3] The system cannot find the path specified: 'D:\\a\\TheRock\\TheRock\\build\\base\\rocm_smi_lib\\stage' (which I was disabling, may need to disable in a few new locations)

@ScottTodd
Copy link
Member Author

Rebased and got a successful run. I'll retry the job a few times to make sure it's stable. Then in a future PR we can switch to one of our self hosted runners / clusters. Right now this mostly exercises the source fetching and baseline CMake configure + build.

@ScottTodd ScottTodd marked this pull request as ready for review February 13, 2025 21:45
@ScottTodd
Copy link
Member Author

Recent runs are 3/3 successes. Merging :D

@ScottTodd ScottTodd merged commit ed4a1e5 into nod-ai:main Feb 13, 2025
2 checks passed
@ScottTodd ScottTodd deleted the windows-ci-setup-2 branch February 13, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants