Skip to content

Comments

[Tuner] Add Fusilli tuner#2817

Open
bangtianliu wants to merge 4 commits intonod-ai:mainfrom
bangtianliu:fusilli-tuner
Open

[Tuner] Add Fusilli tuner#2817
bangtianliu wants to merge 4 commits intonod-ai:mainfrom
bangtianliu:fusilli-tuner

Conversation

@bangtianliu
Copy link
Contributor

@bangtianliu bangtianliu commented Feb 6, 2026

This PR adds a new tuner for operations supported by Fusilli.

The Fusilli tuner follows a similar workflow to the existing BOO Tuner:

  1. Run fusilli_benchmark_driver --dump to generate source MLIR and compile commands
  2. Filter out statistics flags (--iree-scheduling-dump-statistics-*) from compile commands
  3. Generate benchmark files annotated with root_op attributes through adding --iree-config-add-tuner-attributes and --iree-hal-dump-executable-benchmarks-to to the compile commands.
  4. Use tuner to generate optimized tuning specs

Also attached the fusilli tuning log: https://gist.github.com/bangtianliu/bb79ad54f23bf6cec9005fefb99638f7
Assisted-by: Claude Code

@bangtianliu bangtianliu marked this pull request as draft February 6, 2026 21:58
@bangtianliu bangtianliu force-pushed the fusilli-tuner branch 8 times, most recently from e8d2f38 to eb387a7 Compare February 7, 2026 02:59
@bangtianliu bangtianliu marked this pull request as ready for review February 7, 2026 02:59
Copy link
Member

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks OK.

@bangtianliu can you confirm what the code coverage currently is and if we have some function that could use tests.

@bangtianliu bangtianliu requested a review from kuhar February 10, 2026 23:18
@bangtianliu bangtianliu force-pushed the fusilli-tuner branch 2 times, most recently from 9a0da6f to 56dca27 Compare February 12, 2026 18:05
@bangtianliu
Copy link
Contributor Author

cc @kuhar for another look

@kuhar
Copy link
Member

kuhar commented Feb 20, 2026

@bangtianliu can you confirm what the code coverage currently is and if we have some function that could use tests.

Have you checked this?

Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
…d improve code clarity

Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
@bangtianliu
Copy link
Contributor Author

Have you checked this?

Yes. Just added more tests in the latest commit.

Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
@bangtianliu bangtianliu requested a review from kuhar February 20, 2026 17:26
Copy link
Contributor

@RattataKing RattataKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nit

Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
@bangtianliu
Copy link
Contributor Author

cc @kuhar for another look.

@bangtianliu bangtianliu force-pushed the fusilli-tuner branch 3 times, most recently from cdd3f02 to ca5058b Compare February 21, 2026 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants