-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[shortfin llm integration tests] Add tinystories llama2 25m model as a smoke test #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stbaione
reviewed
Feb 13, 2025
stbaione
reviewed
Feb 13, 2025
stbaione
reviewed
Feb 13, 2025
Comments addressed. Re-review pls. Coming next in follow-up prs:
|
stbaione
reviewed
Feb 14, 2025
stbaione
reviewed
Feb 14, 2025
app_tests/integration_tests/llm/shortfin/tinystories_llama2_25m_test.py
Outdated
Show resolved
Hide resolved
stbaione
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tiny model that would take less than a minute to download / export / compile.
The smoke test is intended to run before we run the full integration CI suite. This would give us early visibility into shortfin failures & save CI resources.
This PR adds an integration_tests function to:
model.safetensors
Closes #933