Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some dtype fixes for vae tests #989

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Some dtype fixes for vae tests #989

merged 2 commits into from
Feb 21, 2025

Conversation

IanNod
Copy link
Contributor

@IanNod IanNod commented Feb 21, 2025 •
edited
Loading

Fixes data dependent test failures from VAE

@KyleHerndon KyleHerndon merged commit 5250392 into main Feb 21, 2025
35 of 36 checks passed
@KyleHerndon KyleHerndon deleted the vae_fixes branch February 21, 2025 08:35
@KyleHerndon KyleHerndon mentioned this pull request Feb 21, 2025
Closed
@marbre
Copy link
Collaborator

marbre commented Feb 21, 2025

We had a test failure prior to merging

ERROR sharktank/integration/models/punet/integration_test.py::test_sdxl_export_int8_mlir - Failed: Timeout >600.0s

and PkgCI / Test shark-ai / Integration Test (cpu) (push) failed with a timeout after merging to main. However, this seems unrelated but the patch fixes #982. Thanks @IanNod and @KyleHerndon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleHerndon KyleHerndon KyleHerndon approved these changes

@renxida renxida Awaiting requested review from renxida

@archana-ramalingam archana-ramalingam Awaiting requested review from archana-ramalingam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IanNod @marbre @KyleHerndon