-
-
Notifications
You must be signed in to change notification settings - Fork 624
ci: regenerate release svg automatically #1119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I think it would make sense to create a PR when there is something changed. I wouldn't go redo this because of this suggestion, but you can see a similar workflow in the docker-node repo |
Well, that makes sense, but @nodejs/releasers would have to check, approve the pr and merge every Monday (obligatorily). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good to me, but can we get someone from @nodejs/releasers to check this and agree that auto merge is OK?
Direct push to main sounds scary, especially since this downloads 3rd-party packages from npm (through |
Currently the |
Got it, issue fixed. I also pinned package versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
listo
CC @nodejs/releasers |
I don't think this is worth it, it feels like it's going to be very noisy for little value IMO, and the hard coded version in the |
I don't see any problem, but if anyone don't update the SVG in a while, the website will start displaying misleading info |
The website can (should) generate its own SVG, there's no reason to use the one in this repo |
what do you think @nodejs/nodejs-website? any concerns? |
Related nodejs/nodejs.org#8101
Create a workflow to automatically re-generate the release schedule SVG weekly.