Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Corepack stay in the Node.js distribution? #1697

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 10, 2025

Vote instructions:

To close the vote, at least 3 secret holder(s)1 must run the following command: git node vote https://github.com/nodejs/TSC/pull/1697 --decrypt-key-part --post-comment

/cc @nodejs/tsc

Current estimated participation: 33.33%

Footnotes

  1. secret holders are folks who have access to the private key associated with a public key on hkps://keys.openpgp.org that references an email address listed on the TSC voting member list at the time of the opening of the vote.

@mcollina
Copy link
Member

Didn't work:

remote: Resolving deltas: 100% (3/3), completed with 3 local objects.
remote: error: GH013: Repository rule violations found for refs/heads/votes/e4f313dc-6121-47bb-830d-d85f80d6ee33.
remote: Review all repository rules at https://github.com/nodejs/TSC/rules?ref=refs%2Fheads%2Fvotes%2Fe4f313dc-6121-47bb-830d-d85f80d6ee33
remote:
remote: - Commits must have verified signatures.
remote:   Found 1 violation:
remote:
remote:   8163b99b3b54ff6b9b2753a9146d5072fe7c45d1
remote:
To github.com:nodejs/TSC.git
 ! [remote rejected] HEAD -> votes/e4f313dc-6121-47bb-830d-d85f80d6ee33 (push declined due to repository rule violations)
error: failed to push some refs to 'github.com:nodejs/TSC.git'
Error: git push,[email protected]:nodejs/TSC.git,HEAD:votes/e4f313dc-6121-47bb-830d-d85f80d6ee33 failed: 1
    at ChildProcess.<anonymous> (file:///Users/matteo/.nvm/versions/node/v22.14.0/lib/node_modules/node-core-utils/node_modules/@node-core/caritat/dist/utils/runChildProcessAsync.js:32:27)
    at ChildProcess.emit (node:events:518:28)
    at maybeClose (node:internal/child_process:1101:16)
    at ChildProcess._handle.onexit (node:internal/child_process:304:5)

how can I handle this?

@mcollina
Copy link
Member

mcollina commented Mar 10, 2025

In case you wonder, the correct command is git node vote https://github.com/nodejs/TSC/pull/1697 --gpg-sign I've updated it.

@anonrig anonrig mentioned this pull request Mar 11, 2025
@mcollina
Copy link
Member

@nodejs/tsc please vote.

@anonrig
Copy link
Member

anonrig commented Mar 11, 2025

In case you wonder, the correct command is git node vote https://github.com/nodejs/TSC/pull/1697 --gpg-sign I've updated it.

I couldn't sign it with SSH key. Is GPG the only way?

@aduh95
Copy link
Contributor

aduh95 commented Mar 11, 2025

Is GPG the only way?

No, GitHub supports different kind of signatures, including SSH and PGP.

in future Node.js releases.
method: Condorcet
allowedVoters:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not included in this list because this vote was initiated before the TSC list in the Node.js readme was updated with my info. Do I get to vote anyways or should I just skip?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say skip since it started without you but idk if there is an official rule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants