Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request a token for node-gyp #935

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Request a token for node-gyp #935

merged 2 commits into from
Jan 28, 2025

Conversation

legendecas
Copy link
Member

Refs: nodejs/node-gyp#3105

permissions:
  contents: write
  pull-requests: write

@legendecas legendecas mentioned this pull request Dec 3, 2024
Merged
1 task
mhdawson
mhdawson approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

@legendecas token created/added

@legendecas
Copy link
Member Author

Thanks!

@legendecas legendecas merged commit 46ee242 into nodejs:main Jan 28, 2025
@legendecas legendecas deleted the node-gyp branch January 28, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legendecas @mhdawson @jasnell