Initial implementation from node.js #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anonrig ... do you know why for the CI fails? |
|
@anonrig ... this is ready for review but definitely going to need help figuring out the build/CI stuff. Looks like the boringssl dependency needs to be added to cmake. |
jasnell
force-pushed
the
initial-impl
branch
5 times, most recently
from
c78f4d2 to
e096002
Compare
anonrig
force-pushed
the
initial-impl
branch
4 times, most recently
from
1999a7a to
53e2d10
Compare
anonrig
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on ncrypto as of nodejs/node#56792 plus additional bits from https://github.com/electron/electron/blob/main/patches/node/fix_handle_boringssl_and_openssl_incompatibilities.patch#L93