Skip to content

feat: add warning when fail on all platforms #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2024
Merged

feat: add warning when fail on all platforms #843

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion lib/ci/build-types/citgm_comparison_build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ export class CITGMComparisonBuild {
const { failures: comparisonFailures } = comparisonBuild.results;

const failures = {};
let allPlatformFailures;
for (const platform in comparisonFailures) {
// Account for no failure on this platform, or different platform.
if (!Object.prototype.hasOwnProperty.call(baseFailures, platform)) {
Expand All @@ -66,11 +67,18 @@ export class CITGMComparisonBuild {
if (newFailures.length !== 0) {
result = statusType.FAILURE;
}

if (allPlatformFailures === undefined) {
allPlatformFailures = newFailures;
} else if (allPlatformFailures.length > 0) {
allPlatformFailures = allPlatformFailures.filter(f => {
return newFailures.includes(f);
});
}
failures[platform] = newFailures;
}

this.results.failures = failures;
this.results.allPlatformFailures = allPlatformFailures;
this.result = result;

return result;
Expand Down Expand Up @@ -124,6 +132,12 @@ export class CITGMComparisonBuild {
const str = `${totalFailures} failures in ${cID} not present in ${bID}`;
cli.log(`${statusType.FAILURE}: ${str}\n\n`);
console.table(output);
if (
results.allPlatformFailures &&
results.allPlatformFailures.length) {
const failures = results.allPlatformFailures.join(', ');
console.warn(`These modules failed in all platforms: ${failures}`);
}
}

formatAsJson() {
Expand Down
Loading