Skip to content

Conversation

joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Sep 17, 2025

As node-core-utils are CLI tools, it makes more sense to use shrinkwrap instead of package lock to allow users to install the CLI globally while pining transitive dependencies.

Fixes: #974

As node-core-utils are CLI tools, it makes more sense to use
shrinkwrap instead of package lock to allow users to install
the CLI globally while pining transitive dependencies.
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.75%. Comparing base (c6cfc55) to head (93ee50f).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #976   +/-   ##
=======================================
  Coverage   79.75%   79.75%           
=======================================
  Files          39       39           
  Lines        4663     4663           
=======================================
  Hits         3719     3719           
  Misses        944      944           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@targos
Copy link
Member

targos commented Sep 18, 2025

I hope it's supported by dependabot.

@joyeecheung
Copy link
Member Author

@joyeecheung joyeecheung merged commit c6ae8a4 into nodejs:main Sep 18, 2025
13 checks passed
@targos
Copy link
Member

targos commented Sep 18, 2025

Proven by #971

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pin the dependencies in the published CLI via shrinkwrap
2 participants