Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove support for s390 32-bit #291

Open
wants to merge 14 commits into
base: canary
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
16 changes: 0 additions & 16 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -909,15 +909,9 @@ else
ifeq ($(findstring ppc64,$(UNAME_M)),ppc64)
DESTCPU ?= ppc64
else
ifeq ($(findstring ppc,$(UNAME_M)),ppc)
DESTCPU ?= ppc
else
ifeq ($(findstring s390x,$(UNAME_M)),s390x)
DESTCPU ?= s390x
else
ifeq ($(findstring s390,$(UNAME_M)),s390)
DESTCPU ?= s390
else
ifeq ($(findstring OS/390,$(shell uname -s)),OS/390)
DESTCPU ?= s390x
else
Expand Down Expand Up @@ -947,8 +941,6 @@ endif
endif
endif
endif
endif
endif
ifeq ($(DESTCPU),x64)
ARCH=x64
else
Expand All @@ -961,12 +953,6 @@ else
ifeq ($(DESTCPU),ppc64)
ARCH=ppc64
else
ifeq ($(DESTCPU),ppc)
ARCH=ppc
else
ifeq ($(DESTCPU),s390)
ARCH=s390
else
ifeq ($(DESTCPU),s390x)
ARCH=s390x
else
Expand All @@ -980,8 +966,6 @@ endif
endif
endif
endif
endif
endif

# node and v8 use different arch names (e.g. node 'x86' vs v8 'ia32').
# pass the proper v8 arch name to $V8_ARCH based on user-specified $DESTCPU.
Expand Down
12 changes: 2 additions & 10 deletions common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.15',
'v8_embedder_string': '-node.6',

##### V8 defaults for Node.js #####

Expand Down Expand Up @@ -110,7 +110,7 @@
'v8_base': '<(PRODUCT_DIR)/libv8_snapshot.a',
}],
# V8 pointer compression only supports 64bit architectures.
['target_arch in "arm ia32 mips mipsel ppc"', {
['target_arch in "arm ia32 mips mipsel"', {
'v8_enable_pointer_compression': 0,
'v8_enable_31bit_smis_on_64bit_arch': 0,
'v8_enable_sandbox': 0
Expand Down Expand Up @@ -516,10 +516,6 @@
'cflags': [ '-m64' ],
'ldflags': [ '-m64' ],
}],
[ 'host_arch=="ppc" and OS not in "aix os400"', {
'cflags': [ '-m32' ],
'ldflags': [ '-m32' ],
}],
[ 'host_arch=="ppc64" and OS not in "aix os400"', {
'cflags': [ '-m64', '-mminimal-toc' ],
'ldflags': [ '-m64' ],
Expand All @@ -540,10 +536,6 @@
'cflags': [ '-m64' ],
'ldflags': [ '-m64' ],
}],
[ 'target_arch=="ppc" and OS not in "aix os400"', {
'cflags': [ '-m32' ],
'ldflags': [ '-m32' ],
}],
[ 'target_arch=="ppc64" and OS not in "aix os400"', {
'cflags': [ '-m64', '-mminimal-toc' ],
'ldflags': [ '-m64' ],
Expand Down
2 changes: 1 addition & 1 deletion configure.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@

valid_os = ('win', 'mac', 'solaris', 'freebsd', 'openbsd', 'linux',
'android', 'aix', 'cloudabi', 'os400', 'ios')
valid_arch = ('arm', 'arm64', 'ia32', 'mips', 'mipsel', 'mips64el', 'ppc',
valid_arch = ('arm', 'arm64', 'ia32', 'mips', 'mipsel', 'mips64el',
'ppc64', 'x64', 'x86', 'x86_64', 's390x', 'riscv64', 'loong64')
valid_arm_float_abi = ('soft', 'softfp', 'hard')
valid_arm_fpu = ('vfp', 'vfpv3', 'vfpv3-d16', 'neon')
Expand Down
12 changes: 7 additions & 5 deletions deps/v8/.clang-tidy
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
---
Checks: '-*,
bugprone-unique-ptr-array-mismatch,
# google-build-explicit-make-pair,
google-default-arguments,
google-explicit-constructor,
google-readability-casting,
modernize-redundant-void-arg,
modernize-replace-random-shuffle,
modernize-shrink-to-fit,
Expand All @@ -11,12 +15,10 @@
# modernize-use-equals-delete,
modernize-use-nullptr,
modernize-use-override,
# google-build-explicit-make-pair,
google-default-arguments,
google-explicit-constructor,
google-readability-casting'
performance-inefficient-vector-operation,
performance-trivially-destructible,
performance-unnecessary-copy-initialization'
WarningsAsErrors: ''
HeaderFilterRegex: ''
AnalyzeTemporaryDtors: false
...

6 changes: 3 additions & 3 deletions deps/v8/.editorconfig
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
root = true
# editorconfig.org

[*]
charset = utf-8
indent_style = space
indent_size = 2
end_of_line = lf
indent_size = 2
indent_style = space
insert_final_newline = true
trim_trailing_whitespace = true
7 changes: 5 additions & 2 deletions deps/v8/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,9 @@
/third_party/colorama/src
!/third_party/cpu_features
/third_party/cpu_features/src
!/third_party/fast_float
/third_party/fast_float/src/*
!/third_party/fast_float/src/include
!/third_party/glibc
!/third_party/googletest
/third_party/googletest/src/*
Expand All @@ -88,8 +91,8 @@
!/third_party/test262-harness
!/third_party/v8
!/third_party/wasm-api
/tools/builtins-pgo/profiles/*.profile
/tools/builtins-pgo/profiles/profiles_version
/tools/builtins-pgo/profiles/*
!/tools/builtins-pgo/profiles/.*
/tools/clang
/tools/gcmole/bootstrap
/tools/gcmole/gcmole-tools
Expand Down
10 changes: 9 additions & 1 deletion deps/v8/AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,9 @@ Anton Bershanskiy <[email protected]>
Anton Bikineev <[email protected]>
Ao Wang <[email protected]>
Archil Sharashenidze <[email protected]>
Artem Kobzar <[email protected]>
Arthur Islamov <[email protected]>
Asuka Shikina <[email protected]>
Aurèle Barrière <[email protected]>
Bala Avulapati <[email protected]>
Bangfu Tao <[email protected]>
Expand Down Expand Up @@ -143,11 +145,11 @@ Henrique Ferreiro <[email protected]>
Helmut Januschka <[email protected]>
Hirofumi Mako <[email protected]>
Hisham Muhammad <[email protected]>
Ho Cheung <[email protected]>
Honggyu Kim <[email protected]>
Huáng Jùnliàng <[email protected]>
HyeockJin Kim <[email protected]>
Iain Ireland <[email protected]>
Ilya Gavrilin <[email protected]>
Ingvar Stepanyan <[email protected]>
Ioseb Dzmanashvili <[email protected]>
Isiah Meadows <[email protected]>
Expand All @@ -170,6 +172,7 @@ Joel Stanley <[email protected]>
Johan Bergström <[email protected]>
Johan Levin <[email protected]>
John Paul Adrian Glaubitz <[email protected]>
Jojo R <[email protected]>
Jonathan Liu <[email protected]>
Juan Arboleda <[email protected]>
Julien Brianceau <[email protected]>
Expand Down Expand Up @@ -205,7 +208,9 @@ Matt Hanselman <[email protected]>
Matthew Sporleder <[email protected]>
Maxim Mazurok <[email protected]>
Maxim Mossienko <[email protected]>
Md Hasibul Hasan <[email protected]>
Meir Shpilraien <[email protected]>
Meng Tan <[email protected]>
Michael Lutz <[email protected]>
Michael Mclaughlin <[email protected]>
Michael Smith <[email protected]>
Expand Down Expand Up @@ -264,6 +269,7 @@ Sébastien Doeraene <[email protected]>
Seo Sanghyeon <[email protected]>
Shawn Anastasio <[email protected]>
Shawn Presser <[email protected]>
Sho Miyamoto <[email protected]>
Stefan Penner <[email protected]>
Stefan Stojanovic <[email protected]>
Stephan Hartmann <[email protected]>
Expand Down Expand Up @@ -307,11 +313,13 @@ Youfeng Hao <[email protected]>
Yu Yin <[email protected]>
Yujie Wang <[email protected]>
Yuri Iozzelli <[email protected]>
Yuri Gaevsky <[email protected]>
Yusif Khudhur <[email protected]>
Yuxiang Cao <[email protected]>
Zac Hansen <[email protected]>
Zeynep Cankara <[email protected]>
Zhao Jiazhong <[email protected]>
Zhaojun Meng <[email protected]>
Zheng Liu <[email protected]>
Zhongping Wang <[email protected]>
柳荣一 <[email protected]>
Expand Down
Loading
Loading