Apply suggestions from code review

Co-authored-by: Antoine du Hamel <[email protected]>
nodejs · Nov 14, 2024 · 452c3c2 · 452c3c2
1 parent 23fe596
commit 452c3c2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/.github/workflows/create-release-proposal.yml b/.github/workflows/create-release-proposal.yml
@@ -67,4 +67,4 @@ jobs:
 
       - name: Start git node release prepare
         run: |
-          ./tools/actions/create-release.sh "${RELEASE_DATE}"
+          ./tools/actions/create-release.sh "${RELEASE_DATE}" '${{ inputs.release-line  }}'
diff --git a/tools/actions/create-release.sh b/tools/actions/create-release.sh
@@ -3,12 +3,13 @@
 set -xe
 
 RELEASE_DATE=$1
+RELEASE_LINE=$2
 
 git node release --prepare --skipBranchDiff
 # We use it to not specify the branch name as it changes based on
 # the commit list (semver-minor/semver-patch)
 git config push.default current
-MATCHER="/## $RELEASE_DATE/,/^<a id=/{ if (!/^<a id=/) print }"
-awk $MATCHER doc/changelogs/CHANGELOG_V23.md > pr-body.md
-gh pr create --body-file pr-body.md
+awk "/## ${RELEASE_DATE}/,/^<a id=/{ if (!/^<a id=/) print }" \
+  "doc/changelogs/CHANGELOG_V${RELEASE_LINE}.md" |\
+  gh pr create --body-file -
 # TODO: ammend with proposal PR