Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: move emeritus releasers keys #55399

Closed
wants to merge 3 commits into from

Conversation

RafaelGSS
Copy link
Member

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 15, 2024
@RafaelGSS RafaelGSS requested a review from a team October 15, 2024 21:26
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we only want to remove those lines below:

node/README.md

Lines 799 to 801 in d620755

gpg --keyserver hkps://keys.openpgp.org --recv-keys 4ED778F539E3634C779C87C6D7062848A1AB005C # Beth Griggs
gpg --keyserver hkps://keys.openpgp.org --recv-keys 141F07595B7B3FFE74309A937405533BE57C7D57 # Bryan English
gpg --keyserver hkps://keys.openpgp.org --recv-keys 74F12602B6F1C4E913FAA37AD3A89613643B6201 # Danielle Adams

@RafaelGSS
Copy link
Member Author

Yeah, forgot this list. Done @aduh95

@RafaelGSS RafaelGSS added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 16, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 17, 2024
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/55399
✔  Done loading data for nodejs/node/pull/55399
----------------------------------- PR info ------------------------------------
Title      doc: move emeritus releasers keys (#55399)
Author     Rafael Gonzaga <[email protected]> (@RafaelGSS)
Branch     RafaelGSS:move-releasers-to-emeritus -> nodejs:main
Labels     doc, author ready
Commits    3
 - doc: move Beth Griggs keys to old gpg keys
 - doc: move Bryan English key to old gpg keys
 - doc: move Danielle Adams key to old gpg keys
Committers 1
 - RafaelGSS <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/55399
Refs: https://github.com/nodejs/Release/issues/1036
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/55399
Refs: https://github.com/nodejs/Release/issues/1036
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 15 Oct 2024 21:24:25 GMT
   ✔  Approvals: 6
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/55399#pullrequestreview-2371441522
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/55399#pullrequestreview-2371462331
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/55399#pullrequestreview-2372157292
   ✔  - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/55399#pullrequestreview-2372174427
   ✔  - Ruy Adorno (@ruyadorno) (TSC): https://github.com/nodejs/node/pull/55399#pullrequestreview-2372494599
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/55399#pullrequestreview-2373227526
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 55399
From https://github.com/nodejs/node
 * branch                  refs/pull/55399/merge -> FETCH_HEAD
✔  Fetched commits as 0c68991474a4..25d642d3ef8d
--------------------------------------------------------------------------------
[main faa0d0e547] doc: move Beth Griggs keys to old gpg keys
 Author: RafaelGSS <[email protected]>
 Date: Tue Oct 15 18:20:40 2024 -0300
 1 file changed, 2 insertions(+), 3 deletions(-)
[main 81256ab0ae] doc: move Bryan English key to old gpg keys
 Author: RafaelGSS <[email protected]>
 Date: Tue Oct 15 18:21:56 2024 -0300
 1 file changed, 2 insertions(+), 3 deletions(-)
[main 87fcb7e9fb] doc: move Danielle Adams key to old gpg keys
 Author: RafaelGSS <[email protected]>
 Date: Tue Oct 15 18:22:20 2024 -0300
 1 file changed, 1 insertion(+), 3 deletions(-)
   ✔  Patches applied
There are 3 commits in the PR. Attempting autorebase.
Rebasing (2/6)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: move Beth Griggs keys to old gpg keys

Refs: nodejs/Release#1042
PR-URL: #55399
Refs: nodejs/Release#1036
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

[detached HEAD a8520dd0e7] doc: move Beth Griggs keys to old gpg keys
Author: RafaelGSS <[email protected]>
Date: Tue Oct 15 18:20:40 2024 -0300
1 file changed, 2 insertions(+), 3 deletions(-)
Rebasing (3/6)
Rebasing (4/6)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: move Bryan English key to old gpg keys

Refs: nodejs/Release#1040
PR-URL: #55399
Refs: nodejs/Release#1036
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

[detached HEAD 2e151466dd] doc: move Bryan English key to old gpg keys
Author: RafaelGSS <[email protected]>
Date: Tue Oct 15 18:21:56 2024 -0300
1 file changed, 2 insertions(+), 3 deletions(-)
Rebasing (5/6)
Rebasing (6/6)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: move Danielle Adams key to old gpg keys

Refs: nodejs/Release#1041
PR-URL: #55399
Refs: nodejs/Release#1036
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

[detached HEAD bdc3ddb80a] doc: move Danielle Adams key to old gpg keys
Author: RafaelGSS <[email protected]>
Date: Tue Oct 15 18:22:20 2024 -0300
1 file changed, 1 insertion(+), 3 deletions(-)
Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/11393365042

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 17, 2024
@RafaelGSS RafaelGSS added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 17, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 17, 2024
@nodejs-github-bot
Copy link
Collaborator

Landed in 0c68991...8ac867f

nodejs-github-bot pushed a commit that referenced this pull request Oct 17, 2024
Refs: nodejs/Release#1042
PR-URL: #55399
Refs: nodejs/Release#1036
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Oct 17, 2024
Refs: nodejs/Release#1040
PR-URL: #55399
Refs: nodejs/Release#1036
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Oct 17, 2024
Refs: nodejs/Release#1041
PR-URL: #55399
Refs: nodejs/Release#1036
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit that referenced this pull request Oct 19, 2024
Refs: nodejs/Release#1042
PR-URL: #55399
Refs: nodejs/Release#1036
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit that referenced this pull request Oct 19, 2024
Refs: nodejs/Release#1040
PR-URL: #55399
Refs: nodejs/Release#1036
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit that referenced this pull request Oct 19, 2024
Refs: nodejs/Release#1041
PR-URL: #55399
Refs: nodejs/Release#1036
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@aduh95 aduh95 mentioned this pull request Oct 24, 2024
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
Refs: nodejs/Release#1042
PR-URL: nodejs#55399
Refs: nodejs/Release#1036
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
Refs: nodejs/Release#1040
PR-URL: nodejs#55399
Refs: nodejs/Release#1036
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
Refs: nodejs/Release#1041
PR-URL: nodejs#55399
Refs: nodejs/Release#1036
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants