-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
module: add dynamic file-specific ESM warnings #56628
base: main
Are you sure you want to change the base?
Conversation
621136c
to
777a249
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56628 +/- ##
==========================================
- Coverage 89.19% 89.04% -0.16%
==========================================
Files 662 665 +3
Lines 191893 193420 +1527
Branches 36937 37281 +344
==========================================
+ Hits 171164 172222 +1058
- Misses 13573 13880 +307
- Partials 7156 7318 +162
|
Could this be flakky? but tests to my local is success https://github.com/nodejs/node/actions/runs/12811945783/job/35722483892?pr=56628 |
Co-authored-by: Anna Henningsen <[email protected]>
Co-authored-by: Antoine du Hamel <[email protected]>
The issue was that |
Co-authored-by: Anna Henningsen <[email protected]>
Co-authored-by: James M Snell <[email protected]>
The CI failures are relevant to this change. Looks like a test that needs fixing up and some lint issues to resolve. |
thanks, I updated |
Failed to start CI⚠ Something was pushed to the Pull Request branch since the last approving review. ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/13406809365 |
Co-authored-by: Antoine du Hamel <[email protected]>
lint seems to be warning about the use order but my local cpp-linter says everything is working fine 13:06:32 using statements aren't sorted in 'src/node_process_events.cc'.
13:06:32 Line 17: Actual: v8::Nothing, Expected: v8::NewStringType
13:06:32 Line 18: Actual: v8::Object, Expected: v8::Nothing
13:06:32 Line 19: Actual: v8::String, Expected: v8::Object
13:06:32 Line 20: Actual: v8::Value, Expected: v8::String
13:06:35 Line 21: Actual: v8::NewStringType, Expected: v8::Value
13:06:35 make: *** [Makefile:1549: tools/.cpplintstamp] Error 1 |
I improved the error message to include specific file and package.json details, trying to make it clearer and more actionable as requested in the TODO